Skip to content

Solves missed stashes #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

Solves missed stashes #4468

merged 4 commits into from
Jul 7, 2025

Conversation

@sergeibbb
Copy link
Member

Description

Solves #4401

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Jun 30, 2025 that may be closed by this pull request
The stashes with parent commits older than the oldest stash are not visible on branches #4401
Closed
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Add parent commit timestamp tracking to GitStashCommit model
eec1757 
(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Track and attach parent commit timestamps to stashes in StashGitSubPr…
7dc89e1 
…ovider

(#4401, #4468)
@sergeibbb sergeibbb force-pushed the 4401-missed-stashes branch from 05c2606 to 3162040 Compare June 30, 2025 20:27
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Compute oldest timestamp for stashes including parent commit dates
d70b694 
(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Add tests for findOldestStashTimestamp to cover edge cases and perfor…
3162040 
…mance

(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Add parent commit timestamp tracking to GitStashCommit model
006aeda 
(#4401, #4468)
@sergeibbb sergeibbb force-pushed the 4401-missed-stashes branch from 3162040 to 4cf91cc Compare June 30, 2025 20:27
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Track and attach parent commit timestamps to stashes in StashGitSubPr…
8a76151 
…ovider

(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Compute oldest timestamp for stashes including parent commit dates
1c757e5 
(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jun 30, 2025
@sergeibbb
Add tests for findOldestStashTimestamp to cover edge cases and perfor…
4cf91cc 
…mance

(#4401, #4468)
@sergeibbb sergeibbb marked this pull request as ready for review July 1, 2025 12:10
sergeibbb added a commit that referenced this pull request Jul 1, 2025
@sergeibbb
Add parent commit timestamp tracking to GitStashCommit model
92ce148 
(#4401, #4468)
@sergeibbb sergeibbb force-pushed the 4401-missed-stashes branch from 4cf91cc to 9db1fa2 Compare July 1, 2025 12:11
sergeibbb added a commit that referenced this pull request Jul 1, 2025
@sergeibbb
Track and attach parent commit timestamps to stashes in StashGitSubPr…
39582c2 
…ovider

(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jul 1, 2025
@sergeibbb
Compute oldest timestamp for stashes including parent commit dates
9d5340c 
(#4401, #4468)
sergeibbb added a commit that referenced this pull request Jul 1, 2025
@sergeibbb
Add tests for findOldestStashTimestamp to cover edge cases and perfor…
9db1fa2 
…mance

(#4401, #4468)
d13
d13 approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d13 d13 force-pushed the 4401-missed-stashes branch from 9db1fa2 to 19bd6f8 Compare July 7, 2025 21:53
@d13 d13 merged commit f7facea into main Jul 7, 2025
2 checks passed
d13 pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @d13
Add parent commit timestamp tracking to GitStashCommit model
31d87dc 
(#4401, #4468)
d13 pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @d13
Track and attach parent commit timestamps to stashes in StashGitSubPr…
ae4bf5d 
…ovider

(#4401, #4468)
d13 pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @d13
Compute oldest timestamp for stashes including parent commit dates
24ea659 
(#4401, #4468)
@sergeibbb sergeibbb deleted the 4401-missed-stashes branch July 8, 2025 12:33
@sergeibbb sergeibbb mentioned this pull request Jul 9, 2025
Merged
sergeibbb added a commit that referenced this pull request Jul 9, 2025
@sergeibbb
Silences duplicate-case warnings in test builds
9a9d48d 
(#4481, #4468)
sergeibbb added a commit that referenced this pull request Jul 9, 2025
@sergeibbb
Silences duplicate-case warnings in test builds
f640c13 
(#4481, #4468)
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
@sergeibbb @wlnxing
Silences duplicate-case warnings in test builds
7b39d30 
(gitkraken#4481, gitkraken#4468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

@eamodio eamodio Awaiting requested review from eamodio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The stashes with parent commits older than the oldest stash are not visible on branches

2 participants

@sergeibbb @d13